Conversation
| match_result[strand_flipped_indices, "A2.target"] <- strand_flip(match_result[strand_flipped_indices, "A2.target"]) | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
What should we do with this FIXME?
There was a problem hiding this comment.
Here was just a space character accidentally added during a previous modification—nothing substantial was changed (I went through several attempts to fix it, but eventually realized that simply keeping the original ID was the easiest solution.)
|
Thanks Ru I think the code can be made more general in merging fsusie and SuSiE input, and when LD matrices are Indeed loaded we should be able to do a better size check using purity in the filter LBF part as we discussed yesterday. But it's fine for the time being. I might work with Hao for another round of improvement next week |
|
Thanks @rfeng2023 so this patch is good to merge based on your standards? Just wonder if there are still any known issues. |
yes please @gaow |
2 participants
This commit includes:
allele_qcload_and_extract_ld_matrix, since the LD reference panel is no longer appropriate for two xQTL modalities. This is using original genotype data instead of residual genotype data.get_cormatfrom ColocBoost, for above in sample LD calculation